Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Setting a Baker when an Oven is Deployed #338

Merged

Conversation

keefertaylor
Copy link
Contributor

@keefertaylor keefertaylor commented Dec 1, 2020

Minor improvements for UX:

  • Allow users to set a delegate for an oven at deploy time
  • Rename openOven to deployOven to better reflect what is happening in the operation

Testing done via script: https://gist.github.com/keefertaylor/9a9e1eae1ed3aa0845fe11e6ecff3126
Sample Output:

$ ts-node src/conseil-test.ts

========================================
SANITY CHECKS
========================================
Contract matched: true

========================================
CORE CONTRACT
========================================
Opened a vault in hash: ooKG9FBTtSNBcp9WBrZGMJhrHLuNgwzwQnJW9zWvDxVNfugTdBy
New address: KT1VduAoNFPRLEJJgRiJHCsuveCxQWPTgfvL
sleeping for tx to be included...
good morning!

Opened a vault in hash: onvH6N2UkhrQxiSfkxYD2k2BiQrtLoQ7L71CUucEwMR1TsU79vw
New address: KT19SAzLJSLK5bUiaZXTYwGM8uq52CCTU42q

@keefertaylor keefertaylor changed the base branch from master to release/505 December 1, 2020 03:25
@keefertaylor
Copy link
Contributor Author

CI Failures look unrelated to PR; Please advise if you'd like action taken.

@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anonymoussprocket anonymoussprocket merged commit f766c1e into Cryptonomic:release/505 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants