Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin crash with your mod and Aileron #6

Open
Sunconure11 opened this issue Oct 15, 2022 · 2 comments
Open

Mixin crash with your mod and Aileron #6

Sunconure11 opened this issue Oct 15, 2022 · 2 comments
Assignees
Labels
no priority Work only if there's nothing else to do other mod Not compatible with other mod, needs work from them pending Waiting for something

Comments

@Sunconure11
Copy link

LodestarMC/Aileron#13

Attempting to start the two as of late causes the game to crash really early on.

@Sunconure11 Sunconure11 added the bug Unexpected behavior label Oct 15, 2022
@Crystal-Spider
Copy link
Member

This is due to both mods trying to change the behavior of campires that normally would hurt the entity on them.
Currently the only solution I could think of is that both mods change the code from using a Redirect annotation to using ModifyExpressionValue.
However this requires both mod to add a new plugin for mixins and it's a little to much work as of now for me.
For the moment being I'm sorry but, even if Aileron adopts the new annotation, I won't and the mods will be incompatible.
However at some point in the future I will adopt the new annotation, at which point the incompatibility will depend on whether Aileron will do the same.

@Crystal-Spider Crystal-Spider added the other mod Not compatible with other mod, needs work from them label Dec 3, 2022
@Crystal-Spider Crystal-Spider added pending Waiting for something compatibility Not compatible with other mod, needs work from us low priority Work in due time and removed pending Waiting for something labels Feb 24, 2024
@Crystal-Spider Crystal-Spider added this to the 4.0.0.0 milestone May 28, 2024
@Crystal-Spider
Copy link
Member

With the next huge update for Soul Fire'd, I finally came back to this.
I noticed that I actually can't make use of ModifyExpressionValue, because I need to redirect the call that hurts the entity, and not add an extra condition to determine whether to hurt it or not.

However, Aileron just needs to add some conditions, so it shouldn't redirect the hurt call and instead use ModifyExpressionValue to add its conditions to prevent the call in certain cases.

@Crystal-Spider Crystal-Spider added pending Waiting for something and removed bug Unexpected behavior compatibility Not compatible with other mod, needs work from us low priority Work in due time labels Jun 4, 2024
@Crystal-Spider Crystal-Spider removed this from the 4.0.0 milestone Jun 4, 2024
@Crystal-Spider Crystal-Spider added low priority Work in due time no priority Work only if there's nothing else to do and removed low priority Work in due time labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no priority Work only if there's nothing else to do other mod Not compatible with other mod, needs work from them pending Waiting for something
Projects
Status: Pending
Development

No branches or pull requests

2 participants