managed controller exceptions

Crystal-SDS · Oct 28, 2017 · ea7b8d3 · ea7b8d3
1 parent dd039ea
commit ea7b8d3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/api/controllers/actors/abstract_controller.py b/api/controllers/actors/abstract_controller.py
@@ -111,8 +111,8 @@ def stop_actor(self):
                     metric_actor.detach(self.id, self.get_target())
             if self.consumer:
                 self.consumer.stop_consuming()
-        except NotFoundError as e:
-            logger.error(e)
+        except:
+            pass
         self.host.stop_actor(self.id)
 
     def compute_data(self, metric_data):

diff --git a/api/controllers/views.py b/api/controllers/views.py
@@ -290,7 +290,8 @@ def start_controller_instance(instance_id, controller_name, controller_class_nam
             controller_actors[instance_id].run()
             logger.info("Controller, Started controller actor: "+controller_location)
     except Exception as e:
-        logger.error(str(e))
+        controller_actors[instance_id].stop_actor()
+        del controller_actors[instance_id]
         raise e
 
 
@@ -301,5 +302,5 @@ def stop_controller_instance(instance_id):
             del controller_actors[instance_id]
             logger.info("Controller, Stopped controller actor: " + str(instance_id))
         except Exception as e:
-            logger.error(str(e))
+            del controller_actors[instance_id]
             raise e