Develop #3
Merged
Develop #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user/user data exchange and strengthening the focus on user/app data interactions. The system should no longer try to check whether users are members of the same group, but instead focus on whether applications can access the data they provide to PHPAS for those applications.
newly revisited UI.
thing needed is to also apply them when the application reads these.
considering revamping the way the system works for CIDR storage, while it should work for the purpose it serves, it's far from perfect
implementation to micro-serviced webhooks that does not suck when trying to work with it. The service needs to be able to access the list of apps installed on the server to allow an administator using the new hook app to connect to applications from the list. It would also be recommended to have a way that allows applications integrated with the server to provide a list of hooks that they support. This way a user could potentially manage the hooks from the UI. Probably, the smartest way to achieve this is by letting the app upload a JSON file with supported hooks, captions and descriptions (including hierarchies) On the other hand, apps should be able to create hooks themselves by registering them or checking whether the hooks they need already do exist. Applications should be able to request "transliteration". Sometimes the payload from one app does not fit the API of the receiving app, when the vendor of one of the apps is not ourselves, this could could become a problem if the server does not allow translating the formats slightly.
…ttle issue I have with the contexts. Once that is done I can deploy it.
behavior towards CptnH00k and need to address some minor behavior inconsistencies.
Seems like too minor an issue to not fix. Added a bit of documentation to the context.
A lot of progress has been made towards removing the old webhook mechanism in favor of the new external one. Tasks that are open before I can consider the webhooks to be done: 1. The UI must be available for the webhook management software. Right now CptnH00k is absolutely headless, styleless and unstable. 2. The integrations need to be more stable. The hooks for CptnH00k should be disabled in the interface, in turn, the SSO hooks should be listed somewhere else. 3. The application detail page makes no sense. The secret and appId are shown separately and in seemingly random places, the UI implies that a record, once modified is stored, but it requires the user to click "store"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDPR update.
New webhook mechanism is stable enough to be pushed to master.