Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section Pages may have additional padding on some themes #150

Closed
kevincrafts opened this issue May 24, 2019 · 0 comments
Closed

Section Pages may have additional padding on some themes #150

kevincrafts opened this issue May 24, 2019 · 0 comments
Assignees
@kevincrafts
Labels
bug Something isn't working

Comments

@kevincrafts
Copy link
Member

kevincrafts commented May 24, 2019 •
edited
Loading

Depending on the theme, section pages might have additional padding above and below the content, adding empty white spaces where there should be none.
Screen Shot 2019-05-24 at 10 31 28 AM

Section pages also have an alignment issue when viewed on mobile displays if no additional padding was configured:
Screen Shot 2019-05-28 at 9 49 20 AM
@kevincrafts kevincrafts added the bug Something isn't working label May 24, 2019
@kevincrafts kevincrafts self-assigned this May 24, 2019
kevincrafts added a commit that referenced this issue May 28, 2019
@kevincrafts
removing extra padding on section pages #150
7973590
kevincrafts added a commit that referenced this issue May 28, 2019
@kevincrafts
fixing issue where section page content would not align properly on m…
5dc2054 
…obile displays #150
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into bug/145
94a697d 
* dev:
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing issue where background color classes wouldn't always nest properly #6
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into bug/158
ef24f8a 
* dev:
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing issue where background color classes wouldn't always nest properly #6
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into bug/149
060ef34 
* dev:
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing issue where background color classes wouldn't always nest properly #6
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into bug/142
d79ac0e 
* dev:
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  Update modules/features/cu_home_page/cu_home_page.module
  Adding instructions, adding deprecated label to old fields #3
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing notice if a homepage is set to a path that is not a node #86
  fixing issue where site name had a different line height between front page and other pages #9
  fixing issue where form fields didn't display properly on dark backgrounds #8
  fixing issue where breadcrumbs wouldn't display if a feature image was set #7
  fixing issue where background color classes wouldn't always nest properly #6
  fixing issue where teaser content grid would not display in a column if there wasn't enough text content #4
  adding custom logo to sticky menus, adding .container class to restrict width of sticky menu elements #3
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into feature/48
9eb927e 
* dev:
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  Adding instructions, adding deprecated label to old fields #3
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing issue where background color classes wouldn't always nest properly #6
  adding custom logo to sticky menus, adding .container class to restrict width of sticky menu elements #3
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into bug/118
0bdd96b 
* dev:
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  Update modules/features/cu_home_page/cu_home_page.module
  Adding instructions, adding deprecated label to old fields #3
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing notice if a homepage is set to a path that is not a node #86
  fixing issue where site name had a different line height between front page and other pages #9
  fixing issue where form fields didn't display properly on dark backgrounds #8
  fixing issue where breadcrumbs wouldn't display if a feature image was set #7
  fixing issue where background color classes wouldn't always nest properly #6
  fixing issue where teaser content grid would not display in a column if there wasn't enough text content #4
  adding custom logo to sticky menus, adding .container class to restrict width of sticky menu elements #3
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into abtest-1
b925dc7 
* dev:
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  Update modules/features/cu_home_page/cu_home_page.module
  Adding instructions, adding deprecated label to old fields #3
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing notice if a homepage is set to a path that is not a node #86
  fixing issue where site name had a different line height between front page and other pages #9
  fixing issue where form fields didn't display properly on dark backgrounds #8
  fixing issue where breadcrumbs wouldn't display if a feature image was set #7
  fixing issue where background color classes wouldn't always nest properly #6
  fixing issue where teaser content grid would not display in a column if there wasn't enough text content #4
  adding custom logo to sticky menus, adding .container class to restrict width of sticky menu elements #3
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into feature/39
74eef5b 
* dev: (24 commits)
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  Update modules/features/cu_home_page/cu_home_page.module
  Adding instructions, adding deprecated label to old fields #3
  Correct typo
  Countdown Bundle Feature/49 (#130)
  Campus News BUndle Feature/57 (#140)
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing notice if a homepage is set to a path that is not a node #86
  fixing issue where site name had a different line height between front page and other pages #9
  fixing issue where form fields didn't display properly on dark backgrounds #8
  fixing issue where breadcrumbs wouldn't display if a feature image was set #7
  fixing issue where background color classes wouldn't always nest properly #6
  ...
jwfuller added a commit that referenced this issue Jun 17, 2019
@jwfuller
Merge branch 'dev' into feature/62
c5dc9d4 
* dev: (26 commits)
  Hard coding version of chrome to use with js tests
  fixing type in css that made light page titles the wrong weight #157
  fixing issue where section page content would not align properly on mobile displays #150
  removing extra padding on section pages #150
  fixing horizontal padding issue on shadow theme #151
  adding wider breakpoint for ivory theme #151
  fixing horizontal padding issue on Ivory theme #151
  fixing issue where page title had too much horizontal padding on mobile displays #152
  Update modules/features/cu_home_page/cu_home_page.module
  Adding instructions, adding deprecated label to old fields #3
  Correct typo
  Countdown Bundle Feature/49 (#130)
  Campus News BUndle Feature/57 (#140)
  fixing issue where blocks were not displaying correctly if set to an match height block row and offset icons #106
  Class Notes Feature/69 (#133)
  Livestream Feature/68 (#132)
  fixing issue where drupal blocs, not beans, could not be configured - such as editing block title #121
  fixing notice if a homepage is set to a path that is not a node #86
  fixing issue where site name had a different line height between front page and other pages #9
  fixing issue where form fields didn't display properly on dark backgrounds #8
  ...

# Conflicts:
#	modules/custom/cu_behat_tests/cu_behat_tests.info
#	tests/behat/behat.travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevincrafts kevincrafts

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevincrafts @jwfuller