Backup Failure when file missing

[sanegaming]

Bug Report

System Information

• Operating System (Including distribution name and version number):

1. Windows 10

• AMP version and build date (Always use the version number, 'latest' is not valid!)

1. 2.5.0.8 - 20240502.1

• Which AMP release stream you're using (Mainline, Nightly or FastTrack)

1. Mainline

I confirm:

• that I have searched for an existing bug report for this issue.
• that I am using the latest available version of AMP.
• that my operating system is up-to-date.

Symptoms

• What are you trying to do?
  Take a scheduled backup

• What are you expecting to happen?
  The backup to be taken successfully, without having to stop the server.

• What is actually happening? ('Nothing' is not an acceptable answer!)
  The backup task fails if a file is missing, sometimes games change files while running and it messes with the file index, or a user manually removes a file. If that happens after the index point, then the backup always fails outright.

Reproduction

Have an instance
kick off a backup
delete a file before it was archived
notice failure

[jwitow]

I'm having an issue with V Rising server backups and I believe this is the cause. Since the game seems to trim its own autosaves, they go missing before a backup can be completed. I didn't think this would be the case for every backup attempt, but it has been for every scheduled backup that's been attempted so far. I'm not sure if there's a long period of time between the indexing and the actual backing up or what, because it seems like there would be a slim chance for a save to get trimmed at the exact moment that the files are being archived, but maybe not?

[sanegaming]

Also there is no notification banner when a backup is running via the scheduled task on 2.5.0.10 - 20240521.1

[Marvellanius]

I'm having this issue on a V Rising instance as well, scheduled backups are never completed, stating Failed - Could not find file '/AMP/v-rising/1829350/save-data/Saves/v3/richieworld/AutoSave_10210.save.gz'.
Manually triggering them sometimes does work, so I am imagining this is some sort of race condition as @jwitow seems to suggest

[IceOfWraith]

As a workaround, this shouldn't be an issue if you stop the game server while doing the backup. It's not the best scenario, but there is a way to still get your backups while the issue is looked into.

[sanegaming]

As a workaround, this shouldn't be an issue if you stop the game server while doing the backup. It's not the best scenario, but there is a way to still get your backups while the issue is looked into.

can you provide an example schedule that properly reports the backup completed state to ensure the server isn't started until complete. I've been trying to use wait action but it's not working well for me.

[IceOfWraith]

See the top two triggers here. Should do what you need.