Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate major repairs #184

Closed
wants to merge 2 commits into from
Closed

Generate major repairs #184

wants to merge 2 commits into from

Conversation

Koud-Wind
Copy link
Collaborator

🤔 What type of PR is this? (check all applicable)

  • 🍕 Addition
  • ⌨️ Productivity
  • 🐛 Bug Fix
  • 🔥 Optimization
  • ⚙️ Configuration
  • 🌟 Quality Of Life
  • ✨ Enhancement
  • 📝 Documentation

📝 Description

Fixed configuration (bandit&soldier health/generation rate) and cleaned up some code
This is the third submission, I don't know if it meets your requirements

🚦 Testing

  • Server
  • Client
  • Client and server testing for other computers

@Desoroxxx
Copy link
Collaborator

Accept the invite I sent you, just realized Paneedah never added you...

Anyway accept it and you will be able to create branch on this repo no need for your fork anymore

@Desoroxxx
Copy link
Collaborator

This is not really a step in the good direction you took out hot reloadability

@Koud-Wind
Copy link
Collaborator Author

This is not really a step in the good direction you took out hot reloadability

But this at least fixed the problem of bandits and soldiers generating

@Desoroxxx
Copy link
Collaborator

Yeah but it needs to be fixed without making the config worst

@Koud-Wind
Copy link
Collaborator Author

Waiting for my further improvement.

@Koud-Wind
Copy link
Collaborator Author

Koud-Wind commented Jun 28, 2023

This seems to be unable to hot reload. At the moment the game is launched, the entity has already been built and cannot be changed based on existing value

@Koud-Wind Koud-Wind marked this pull request as ready for review June 29, 2023 04:02
@Koud-Wind
Copy link
Collaborator Author

@Desoroxxx If this is feasible, I will soon merge it

@Desoroxxx
Copy link
Collaborator

Accept the invite I sent you, just realized Paneedah never added you...

Anyway accept it and you will be able to create branch on this repo no need for your fork anymore

Please do this, I want to test this before any kind of review

@Koud-Wind
Copy link
Collaborator Author

Accept the invite I sent you, just realized Paneedah never added you...
Anyway accept it and you will be able to create branch on this repo no need for your fork anymore

Please do this, I want to test this before any kind of review

I know, I will do this next time I make changes

@Desoroxxx
Copy link
Collaborator

Yeah but:

  1. This is not up to date with Master
  2. I can't test it without it being a branch

@Koud-Wind Koud-Wind closed this Jul 8, 2023
@Koud-Wind Koud-Wind deleted the Generate-major-repairs3 branch December 27, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants