Added custom death messages (#143) #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desoroxxx
requested changes
Jul 15, 2023
|
@Desoroxxx NPE issue has been resolved. |
Desoroxxx
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What type of PR is this? (check all applicable)
📝 Description
Added custom death messages for when someone gets shot!
Current message: "{Player1} was by {Player2} using {WeaponName}"
🚦 Testing
Tested this feature using LAN, since servers are still not working (@Desoroxxx we need that fixed).
⏮️ Backwards Compatibility
Players who do not have the same version as server (or with a lang file that doesn't contain it) will just see
death.attack.gun.All languages (apart from
en_US) will need to update.📖 Added to documentation?