enabling to use double underscore delimiters #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1 +/- ##
===========================================
+ Coverage 87.87% 88.40% +0.52%
===========================================
Files 5 5
Lines 66 69 +3
===========================================
+ Hits 58 61 +3
Misses 8 8
Continue to review full report at Codecov.
|
|
Great! Always glad to hear that someone is using this nuget :) Could you also add test case for this? Thank you! |
|
OK, I'll try it. please wait a moment. |
Cultti
added a commit
that referenced
this pull request
Apr 19, 2021
Release 1.1.0. Added features: - Support multi level configurations with double underscores (__). Thank you mhirasawa-sansan! #1
|
I appreciate your kindness and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for developing a very useful and simple library.
In my project, I needed to use a hierarchical configuration, so I added it.
Using (
__) for SecretID, covert to:. (It will be interpreted as a delimiter by the configuration provider https://github.com/aspnet/Configuration/blob/master/src/Config.Abstractions/ConfigurationPath.cs#L17)This implementation is based on the following documentation and source code.
https://docs.microsoft.com/aspnet/core/fundamentals/configuration/?view=aspnetcore-5.0#environment-variables
https://github.com/aspnet/Configuration/blob/master/src/Config.EnvironmentVariables/EnvironmentVariablesConfigurationProvider.cs#L65-L68
Thank you.