Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added state & condition to check and show UnderHeader component #50

Conversation

sdthaker
Copy link
Contributor

@sdthaker sdthaker commented Oct 10, 2023

Changes made:

  • Added state to show or hide UnderHeader component, its value being either true or false.
  • Added condition in the JSX to only show the UnderHeader component when the state's value is true
  • Added condition in the submit handler to set the state that controls the showing/hiding of the UnderHeader component based on a number of results we receive from, YouTube API. If we have 0 results, show the UnderHeader component or hide it.

Changes in action:

7dcc59bd-2ffe-471a-b7f3-a44d80e497a9.mp4

Issue:

Additional Notes

Please let me know if you want something added/removed as part of this PR, eg., if you'd want me to follow certain naming conventions, logical/conditional changes, etc. @arjxn-py

@netlify
Copy link

netlify bot commented Oct 10, 2023

👷 Deploy request for curiocic pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e66ad12

@vercel
Copy link

vercel bot commented Oct 10, 2023

@sdthaker is attempting to deploy a commit to the cur-io Team on Vercel.

A member of the Team first needs to authorize it.

@arjxn-py arjxn-py self-requested a review October 11, 2023 17:42
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdthaker, looks awesome.

@arjxn-py arjxn-py merged commit 81853b7 into Curio-org:main Oct 11, 2023
0 of 2 checks passed
@arjxn-py arjxn-py linked an issue Oct 11, 2023 that may be closed by this pull request
@sdthaker
Copy link
Contributor Author

Thanks for the prompt review and for merging it. Wonderful project! Hope to contribute to this repo more often! 🙂

@arjxn-py
Copy link
Member

Wonderful project! Hope to contribute to this repo more often! 🙂

Thanks so much to get involved 😃, really appreciate.
Feel free to open issues as well which you feel can improve the project
Happy to have you onboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disappear underheader when video suggestions are loaded
2 participants