New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Image Draw Scope #4
base: main
Are you sure you want to change the base?
Conversation
I've added the ability for the particles to be drawn as bitmap images if required. |
Awesome!!! |
alpha = alpha, | ||
topLeft = Offset(x, y) | ||
) | ||
}else{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind running ktlint once? 🙏🏼
I haven't set anything up on this repo with github actions as this was just an experiment but I'll surely do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, I should have time this weekend to do it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I ran ktlint against this:
https://github.com/Smithyis1337/compose-particle-system/actions/runs/2646726589
This was my first time using ktlint as I am a .net developer (just doing Kotlin for a personal project), so if its not right let me know 😃
@@ -9,6 +9,8 @@ import androidx.compose.foundation.layout.fillMaxSize | |||
import androidx.compose.runtime.Composable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also share a video/gif using particle image bitmap 😄? I could add this to README.md then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gfycat.com/thankfulmeaslygroundbeetle
There is a short video here of sleeping cat particles being fired up using the fountain method 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Given your changes, the image should be small enough so it can be rendered without lag, right?
No description provided.