-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): allow SF7 #12
Conversation
302a76b
to
10b0cce
Compare
How can we help getting this in? |
Hi @simPod thanks for the contribution! However I'd prefer to keep Symfony 5.4 in the supported versions range, as it is still maintained until November 2025. I think I'd like to adapt the pipeline as well to include a new matrix that will test Symfony 5.4 + 6.4 + 7.x, do you have any experience in doing that? |
- Replace require of v6.3 with v6.4
@romm CI is not running for me here but should be fine now https://github.com/simPod/Valinor-Bundle/actions/runs/7421109427 |
Thank you @simPod! |
@romm btw it is missing in release notes |
Hi @simPod, I'm currently investigating for #17 and I was wondering why you came with the WarmUpCompatibility.php file? Adding the However, as described in #17, a deprecation message is fired when the parameter is missing in Symfony 6.4. Could we just add the parameter
Yeah sorry it's because it was a |
Hm , I see 6.4 does not have that arg either https://github.com/symfony/http-kernel/blob/6.4/CacheWarmer/WarmableInterface.php I tried to update it #18 |
chore(deps): allow SF7
Drop support for SF v5