Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): allow SF7 #12

Merged
merged 1 commit into from
Jan 13, 2024
Merged

chore(deps): allow SF7 #12

merged 1 commit into from
Jan 13, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Dec 10, 2023

chore(deps): allow SF7

  • Replace require of v6.3 with v6.4
  • Drop support for SF v5

@kimhemsoe
Copy link

How can we help getting this in?

@romm
Copy link
Member

romm commented Jan 4, 2024

Hi @simPod thanks for the contribution! However I'd prefer to keep Symfony 5.4 in the supported versions range, as it is still maintained until November 2025.

I think I'd like to adapt the pipeline as well to include a new matrix that will test Symfony 5.4 + 6.4 + 7.x, do you have any experience in doing that?

- Replace require of v6.3 with v6.4
@simPod
Copy link
Contributor Author

simPod commented Jan 5, 2024

@romm romm merged commit cc08149 into CuyZ:master Jan 13, 2024
11 checks passed
@romm
Copy link
Member

romm commented Jan 13, 2024

Thank you @simPod!

@simPod simPod deleted the sf7 branch January 13, 2024 21:28
@simPod
Copy link
Contributor Author

simPod commented Jan 13, 2024

@romm btw it is missing in release notes

@romm
Copy link
Member

romm commented Jan 18, 2024

Hi @simPod, I'm currently investigating for #17 and I was wondering why you came with the WarmUpCompatibility.php file? Adding the string $buildDir = null parameter to the warmUp method doesn't seem to bother Symfony for version 5.4 and 6.4 (should not be a breaking change for PHP either?).

However, as described in #17, a deprecation message is fired when the parameter is missing in Symfony 6.4.

Could we just add the parameter $buildDir to the method? Do you see something wrong with it?

@romm btw it is missing in release notes

Yeah sorry it's because it was a chore commit so not taken in the changelog script. 😅

@simPod
Copy link
Contributor Author

simPod commented Jan 19, 2024

Hm , I see 6.4 does not have that arg either https://github.com/symfony/http-kernel/blob/6.4/CacheWarmer/WarmableInterface.php

I tried to update it #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants