misc!: remove deprecated method to set cache directory

It is now mandatory to register cache instances using the method `\CuyZ\Valinor\MapperBuilder::withCache()`.
CuyZ · Nov 23, 2022 · b0d6d2f · b0d6d2f
1 parent ceb1972
commit b0d6d2f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 20 deletions.
diff --git a/src/MapperBuilder.php b/src/MapperBuilder.php
@@ -4,7 +4,6 @@
 
 namespace CuyZ\Valinor;
 
-use CuyZ\Valinor\Cache\FileSystemCache;
 use CuyZ\Valinor\Library\Container;
 use CuyZ\Valinor\Library\Settings;
 use CuyZ\Valinor\Mapper\ArgumentsMapper;
@@ -421,23 +420,6 @@ public function filterExceptions(callable $filter): self
         return $clone;
     }
 
-    /**
-     * @deprecated instead, use:
-     *
-     * ```php
-     * (new \CuyZ\Valinor\MapperBuilder())
-     *     ->withCache(new FileSystemCache('cache-directory'))
-     *     ->mapper()
-     *     ->map(SomeClass::class, [
-     *         // …
-     *     ]);
-     * ```
-     */
-    public function withCacheDir(string $cacheDir): self
-    {
-        return $this->withCache(new FileSystemCache($cacheDir));
-    }
-
     /**
      * Warms up the injected cache implementation with the provided class names.
      *

diff --git a/tests/Unit/MapperBuilderTest.php b/tests/Unit/MapperBuilderTest.php
@@ -38,7 +38,6 @@ public function test_builder_methods_return_clone_of_builder_instance(): void
         $builderI = $builderA->allowPermissiveTypes();
         $builderJ = $builderA->filterExceptions(fn () => new FakeErrorMessage());
         $builderK = $builderA->withCache(new FakeCache());
-        $builderL = $builderA->withCacheDir(sys_get_temp_dir());
 
         self::assertNotSame($builderA, $builderB);
         self::assertNotSame($builderA, $builderC);
@@ -50,7 +49,6 @@ public function test_builder_methods_return_clone_of_builder_instance(): void
         self::assertNotSame($builderA, $builderI);
         self::assertNotSame($builderA, $builderJ);
         self::assertNotSame($builderA, $builderK);
-        self::assertNotSame($builderA, $builderL);
     }
 
     public function test_mapper_instance_is_the_same(): void