Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rdtsc pattern for Unreal Championship #1310

Merged
merged 1 commit into from Jul 1, 2018
Merged

Add new rdtsc pattern for Unreal Championship #1310

merged 1 commit into from Jul 1, 2018

Conversation

jackchentwkh
Copy link
Contributor

please don't merge it yet.
this commit add rdtsc patterns for Unreal Championship. but I don't have time to check whether it introduces false positive in other titles or not.
this PR is only for testers to check whether they have different behaviors with UC.

@gandalfthewhite19890404
Copy link
Contributor

gandalfthewhite19890404 commented Jun 24, 2018

Still crashing if you try to start match - tested on IG-036 1.1285 PAL+NTSC:
Received Exception Code 0xC0000005 @ EIP := 0x04070F2C

@jackchentwkh
Copy link
Contributor Author

Confirmed with PAL version of UC.
bad dump is the root cause of crash. I can get into different play mode with or without this rdtsc patch update with a good dump of UC.
one thing interesting is that when I enter tutorial mode, and get back to menu, then start a new game, UC will crash then. but this is unrelated to rdtsc.

@jarupxx
Copy link
Contributor

jarupxx commented Jun 25, 2018

Is 01 of WMVDEC section certainly rdtsc?
This chunk has lots of strange opcodes, perhaps this chunk is not executable, I think.

@jackchentwkh
Copy link
Contributor Author

yeah, I have similar feeling regarding to the possible rdtsc in WMVDEC.
frankly speaking, I have no idea about it.
but whether patch it as rdtsc or not, seems the intro movies play fine.

@RadWolfie
Copy link
Member

RadWolfie commented Jun 25, 2018

Tester report, Unreal 2, Cxbx-Reloaded/game-compatibility#427 for AIs are fixed. See video comment for reference before pull request was made.

Another reason we want to merge this pull request.

EDIT: Video with proof AI works from different map in Unreal 2 title. https://www.youtube.com/watch?v=foBQYIbxJaU

@jarupxx
Copy link
Contributor

jarupxx commented Jun 26, 2018

@jackchentwkh Confirmed, Unreal 2 (U2_Retail.xbe) uses opcode pattern 01 in section .text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants