Fix a crash when converting certain, large vertex shaders #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows DOA3 to play again after it was broken by the HLSL work. The cause of the crash was a Stack Overflow when compiling the shader, caused by allocating a large object on the stack. Instead, this commit allocates the XboxVertexShaderDecoder on the heap instead, which thanks to the unique_ptr smart pointer, automatically gets freed when it goes out of scope.
LukeUsher
commented
Jan 1, 2020
| @@ -1615,7 +1615,7 @@ extern HRESULT EmuRecompileVshFunction | |||
| { | |||
| XTL::X_VSH_SHADER_HEADER* pXboxVertexShaderHeader = (XTL::X_VSH_SHADER_HEADER*)pXboxFunction; | |||
| uint32_t* pToken; | |||
| XboxVertexShaderDecoder VshDecoder; | |||
| std::unique_ptr<XboxVertexShaderDecoder> VshDecoder = std::make_unique<XboxVertexShaderDecoder>(); | |||
There was a problem hiding this comment.
This object was too large for the stack, causing D3DCompile to trigger a stack overflow exception in some titles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows DOA3 to play again after it was broken by the HLSL work.
The cause of the crash was a Stack Overflow when compiling the shader,
caused by allocating a large object on the stack.
Instead, this commit allocates the XboxVertexShaderDecoder on the heap
instead, which thanks to the unique_ptr smart pointer, automatically
gets freed when it goes out of scope.