Upstream Chihiro Non-LLE Code #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
file-system
ergo720
reviewed
Jun 20, 2021
LukeUsher
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Overall looks good:
Just a heads up that long-term/in the future: g_bIsChihiro will need to be true for any XBE that runs in Chihiro mode, false otherwise, rather than being set purely based on the Xbe type.
Perhaps we should rename it or add another variable for "IsEmulatingChihiro" or something, to allow Xbox mode to still be used for games like Virtua Cop 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will be the last pull request to move chihiro relative changes. Then any rebases on wip Chihiro will be easier management to continue the work.
With addition to the changes, I added a check if system/xbe are detected to run as Chihiro type will force failure. Chihiro support is still under major work in progress and being work on a separate branch.
I'm requesting @LukeUsher to verify any changes made here are good to go.