New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the lightgun input device #2294
Conversation
Tested against GunValkyrie and Steel Battalion, two titles that had controller issues that were fixed within the past year. Neither title shows input-based regressions in this PR. |
beef3b5
to
a1c838a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few small remarks, and admittedly I didn't review very thoroughly, but this looks fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
This adds support for a new input device, the lightgun, specifically the EMS TopGun II documented in the xboxdevwiki. The laser pointer of the gun is also emulated as a circle drawn as an Imgui overlay over the rendering window, so that players can know where they are shooting at on the rendering window. Note that this will only work with xbox games that use xinput to control the lightgun, and thus it won't work with chihiro games that use JVS input instead.
Known xbox games that support lightguns are: