colorsign work, not for merge #2434
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LORKEYOP, COLORKEYCOLOR (just like ALPHAKILL) in HLSL (both Fixed Function and regular template-based converted shaders). For this, a conversion function was added for L6U5V5 texture format (again based on research medievil did : thanks!). Also added tooling to the conversion functions, to make the code (somewhat) more readable and reduce the chance for errors.
…-to-unsigned mapping
…-to-unsigned mapping
…xemu over the past years
…ource registration function (and only use GetDesc if the caller doesn't have access to those variables). This results in seemingly correct values in g_HostTextureFormats[], but this hits the next hurdle : XboxColorSign isn't always set when it should be, resulting in unintentional signed_to_unsigned mapping for signed host formats like D3DFMT_L6V5U5 (if natively supported). Another area that still needs improvement, is texture component swizzling (we can determine the requirements from kelvin_color_format_map).
…ess checks inter-INdependent, and apply a fix that helps the BumpMap samples (as discovered by medievil)
Instead, load it from file, just like our FixedFunctionPixelShader (Note, that this CxbxPixelShaderTemplate.hlsl is already installed into the correct hlsl resource folder.)
added to XBconvert
somehow was disabled here already in master
// TODO : Better check pHostResource class type
github-actions
bot
added
HLE
…h it) in the tooling functions I used in the libyuv-derived color conversion functions.
|
Hi @medievil1, would this pull request better off mark as draft than ready for review/merge status? |
yes, just did not see the option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is for study and example... code is NOT clean and tidy...lol
does build and colorsign seems to work....
contains a mishmash of stuff I cobbled together after losing previous work do to HDD failure