Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merged ALIAS OOVPA with multiple patterns into one (part 2) #366

Merged
merged 15 commits into from
Apr 13, 2017
Merged

merged ALIAS OOVPA with multiple patterns into one (part 2) #366

merged 15 commits into from
Apr 13, 2017

Conversation

jarupxx
Copy link
Contributor

@jarupxx jarupxx commented Apr 13, 2017

Continuation of PR #333 .
I have completed this task #323 except for D3DDevice_SetVertexShaderConstant1Fast.

@jarupxx
Renamed D3DDevice_SetTileNoWait to D3DDevice_SetTile
ae8a223 
Dxbx note : SetTile is applied to SetTileNoWait in Cxbx 4361 OOPVA's!
@jarupxx
Added D3DDevice_KickPushBuffer stub
cc1cc0d
@jarupxx
D3DDevice_KickOff (4134) is not use ALIAS
7ffdb8d
@jarupxx
Renamed XMountAlternateTitle to XMountAlternateTitleA
d20d7da
@jarupxx
Renamed XUnmountAlternateTitle to XUnmountAlternateTitleA
8bc90d8
@jarupxx
Renamed XLaunchNewImage to XLaunchNewImageA
b61f932
@jarupxx
Improved IDirectSoundBuffer_SetAllParameters
17eb1b2 
According to DXBX this function uses "DS_OK" as the return value.
@jarupxx
Renamed IDirectSoundStream_SetHeadroom to DirectSound_CDirectSoundStr…
9983730 
…eam_SetHeadroom
@jarupxx
Improved IDirectSoundStream_SetVolume ALIAS
7303922
@jarupxx
Improved IDirectSoundBuffer_StopEx ALIAS
bea7454 
Note: This function will fail to detect?
@jarupxx
Renamed DirectSound_CDirectSoundStream_SetMixBinVolumes to DirectSoun…
b374c54 
…d_CDirectSoundStream_SetMixBinVolumes2 (5788-5849)
@jarupxx
Renamed IDirectSoundStream_SetMixBins to DirectSound_CDirectSoundStre…
0e8f6ac 
…am_SetMixBins
@jarupxx
Improved DirectSound_CDirectSound_CreateSoundStream ALIAS
0c312f2
@jarupxx
Renamed IDirectSound_EnableHeadphones to IDirectSound8_EnableHeadphon…
4b6b76f 
…es (5558-5788)
@jarupxx
Disabled D3D_CreateDeviceX (From D3D8X) (4627)
fe8589c
@PatrickvL
Copy link
Member

Wow, that's a lot of work! Did you already do regressions tests? And with what titles?

@jarupxx
Copy link
Contributor Author

jarupxx commented Apr 13, 2017

Okay, I used the following titles for regressions tests. All titles passed.

Azurik - Rise of Perathia (3911)
Halo (3925)
Jet Set Radio Future (4134)
Smashing Drive (4242)
Crash Bandicoot - Wrath of Cortex (4361)
Buffy the Vampire Slayer (4432)
Crazy taxi 3 (4531)
Turok - Evolution (4627)
Quantum Redshift (4721)
Namco Museum (4831)
Shikigami no Shiro Evolution - Red (5028)
Otogi (5120)
All-Star Baseball 2004 (5233)
Starsky And Hutch (5344)
Star Wars - Knights of the Old Republic (5455)
Battlestar Galactica (5558)
XIII (5558)
Dance Dance Revolution Ultramix (5659)
All-Star Baseball 2005 (5788)
Puyo Pop Fever (5849)
Forza Motorsport (5849)

@LukeUsher
Copy link
Member

Nice, that's fairly rigorous testing
I'm satisfied with that

@LukeUsher LukeUsher merged commit 503234b into Cxbx-Reloaded:master Apr 13, 2017
@ObiKKa
Copy link

ObiKKa commented Apr 14, 2017

And with that, you've passed Echelon9 into 3rd place on the contributions list. Congratulations!

@jarupxx
Copy link
Contributor Author

jarupxx commented Apr 14, 2017

@ObiKKa Thank you for your congratulations! I'm happy. I think this project is going very fun!

@jarupxx jarupxx deleted the Remove-ALIAS-OOVPA branch April 14, 2017 10:52
This was referenced Apr 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jarupxx @PatrickvL @LukeUsher @ObiKKa