Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snap icon in os's app launchers #1

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Added snap icon in os's app launchers #1

merged 2 commits into from
Sep 8, 2021

Conversation

shikharvashistha
Copy link
Contributor

Greetings of the day,

Please review the pr and let me know in case of any changes if required.

Thanks & Regards
Shikhar Vashistha

Fixes : CyBear-Jinni/cbj_app#273
Reference : here

@guyluz11 guyluz11 self-requested a review September 8, 2021 09:03
@guyluz11
Copy link
Collaborator

guyluz11 commented Sep 8, 2021

Hi @shikharvashistha cool to see you around.

There are two easy things left to do.

  • Write a comment on the issue that you would like to work on it, GitHub doesn't let me assign it to you without a comment on the issue.
    Just write down something like, 'I would be happy to work on this issue." should be good.

  • I have uploaded the company logo in the issue, please update the pull request to use our logo instead of snapcraft logo.

@shikharvashistha
Copy link
Contributor Author

  • I would be happy to work on this issue

Hi @shikharvashistha cool to see you around.

There are two easy things left to do.

  • Write a comment on the issue that you would like to work on it, GitHub doesn't let me assign it to you without a comment on the issue.
    Just write down something like, 'I would be happy to work on this issue." should be good.
  • I have uploaded the company logo in the issue, please update the pull request to use our logo instead of snapcraft logo.

Done ! 👍

@guyluz11
Copy link
Collaborator

guyluz11 commented Sep 8, 2021

Looks good thanks.

Feel free to star CyBear-Jinni reos if your want to show your support, you are welcome to join the community in the discord server.

We probably going to join Hacktoberfest this year too so you are welcome to join.

@guyluz11 guyluz11 merged commit e99cbd9 into CyBear-Jinni-user:main Sep 8, 2021
guyluz11 added a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap icon does not show in os's app launchers
2 participants