Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap icon does not show in os's app launchers #273

Closed
guyluz11 opened this issue Sep 5, 2021 · 12 comments · Fixed by CyBear-Jinni-user/CBJ_App_Snap#1
Closed

Snap icon does not show in os's app launchers #273

guyluz11 opened this issue Sep 5, 2021 · 12 comments · Fixed by CyBear-Jinni-user/CBJ_App_Snap#1
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@guyluz11
Copy link
Member

guyluz11 commented Sep 5, 2021

After downloading a snap the icon of the snap should be added to the app launchers of the different Linux os's.
We are probably missing a small section in the snapcraft.yaml that will set it up with app icon and all.

image

The snapcraft.yaml file can be found in the app snap repo

https://github.com/CyBear-Jinni-user/CBJ_App_Snap

@guyluz11
Copy link
Member Author

guyluz11 commented Sep 8, 2021

@shikharvashistha
Copy link

Greetings of the day @guyluz11,

I would be happy to work on this issue

Thanks & Regards
Shikhar Vashistha

@guyluz11
Copy link
Member Author

guyluz11 commented Sep 8, 2021

@shikharvashistha sure, this issue is now in your hands :) .

@guyluz11
Copy link
Member Author

guyluz11 commented Sep 9, 2021

I have accidentally closed the Issue without checking.
There was an error building the snap, I have fixed it (build using flutter stable instead of flutter master).

Now after building the snap I still can't see our snap logo in my luncher running on Kubuntu.
Can your try installing the snap on your Linux machine and report?, it can be downloaded from the last stable release in the snap store.

@guyluz11 guyluz11 reopened this Sep 9, 2021
@shikharvashistha
Copy link

I have accidentally closed the Issue without checking.
There was an error building the snap, I have fixed it (build using flutter stable instead of flutter master).

Now after building the snap I still can't see our snap logo in my luncher running on Kubuntu.
Can your try installing the snap on your Linux machine and report?, it can be downloaded from the last stable release in the snap store.

Reference used : here

@guyluz11
Copy link
Member Author

Found this while creating the snap

The 'snap' directory is meant specifically for snapcraft, but it contains the following non-snapcraft-related paths, which is unsupported and will cause unexpected behavior:
- setup
- setup/gui
- setup/gui/icon.png

If you must store these files within the 'snap' directory, move them to 'snap/local', which is ignored by snapcraft.

I think what you referenced is deprecated.

@shikharvashistha
Copy link

Found this while creating the snap

The 'snap' directory is meant specifically for snapcraft, but it contains the following non-snapcraft-related paths, which is unsupported and will cause unexpected behavior:
- setup
- setup/gui
- setup/gui/icon.png

If you must store these files within the 'snap' directory, move them to 'snap/local', which is ignored by snapcraft.

I think what you referenced is deprecated.

Greetings of the day @guyluz11,

I've also gone through the official documentation here and it suggests the same.

Thanks & Regards
@shikharvashistha

@guyluz11
Copy link
Member Author

As you can see in my picture this is only a fork of the official documentation, and it is was last updated in 2016.

image

@shikharvashistha
Copy link

shikharvashistha commented Sep 11, 2021

Greetings of the day @guyluz11,

In my opinion the icon could be added in this way otherwise I'll follow the procedure mentioned here What do you suggest ?

Thanks & Regards
@shikharvashistha

@guyluz11
Copy link
Member Author

guyluz11 commented Sep 11, 2021

@shikharvashistha Your first link from StackExchange askUbuntu is also from 2016.
I think your second link is ok and another good place that I found is from snapcraft-yaml-reference in the icon section

Note that the desktop menu does not use this icon. It uses the icon in the .desktop file of the application.

Under apps. <app-name>. autostart it is written about .desktop file

the name of the autostart .desktop file.
Type: string
The desktop file is placed in $SNAP_USER_DATA/.config/autostart, and the application is started using the app’s command wrapper. See Snapcraft parts metadata for further details.

Also an example of one that works is always good, I have found one (didn't test it but looks good)

https://github.com/ferraridamiano/ConverterNOW/tree/master/snap/gui

It looks like we are missing a cybear-jinni.desktop file and the snap/gui/icon should work but I think using snap/gui/icon is old method and we should not use it.

@shikharvashistha
Copy link

shikharvashistha commented Sep 13, 2021

@shikharvashistha Your first link from StackExchange askUbuntu is also from 2016.
I think your second link is ok and another good place that I found is from snapcraft-yaml-reference in the icon section

Note that the desktop menu does not use this icon. It uses the icon in the .desktop file of the application.

Under apps. <app-name>. autostart it is written about .desktop file

the name of the autostart .desktop file.
Type: string
The desktop file is placed in $SNAP_USER_DATA/.config/autostart, and the application is started using the app’s command wrapper. See Snapcraft parts metadata for further details.

Also an example of one that works is always good, I have found one (didn't test it but looks good)

https://github.com/ferraridamiano/ConverterNOW/tree/master/snap/gui

It looks like we are missing a cybear-jinni.desktop file and the snap/gui/icon should work but I think using snap/gui/icon is old method and we should not use it.

Greetings of the day @guyluz11,

I guess both of the links (one provided by you and me) suggest the same usage of It looks like we are missing a cybear-jinni.desktop file and the snap/gui/icon should work but I think using snap/gui/icon is old method and we should not use it.. I've created a pull here

Thanks & Regards
@shikharvashistha

@guyluz11
Copy link
Member Author

Looks good

image

Will close now the issue.

Thanks @shikharvashistha for all the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants