Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typings #60

Merged
merged 1 commit into from
Mar 8, 2021
Merged

add typings #60

merged 1 commit into from
Mar 8, 2021

Conversation

RobinRadic
Copy link
Contributor

Untested and far from ideal. But it should work.

fixes #59

@RobinRadic RobinRadic mentioned this pull request Mar 1, 2021
@mesqueeb mesqueeb merged commit 9de118b into CyCraft:production Mar 8, 2021
@a21ns1g4ts
Copy link

@RobinRadic Usually we return id integer. If we can change the type to Number ?

@mesqueeb
Copy link
Member

@a21ns1g4ts this will break a lot of the library I believe where we check for the ID and expect a string.

You could fork the library and try changing it to number, see where it works and where you need to tweak it.

PR's welcome!

@a21ns1g4ts
Copy link

So ok. I will try a practical way to get around the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typescript types
3 participants