-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile in release tarball does not contain the install targets #111
Comments
Which change, or patch, would you like ? |
ah ok, since the change in the title, the issue is clearer. Indeed, |
Yes, I'm picking the release tarball. Maybe just creating a new release would be fine, then. Thanks! |
Thanks! As a side note, shouldn't the header be installed on |
Maybe creating a small library with the hash functions would be useful for other projects. |
Right, As a reference point, it would be good to know how it works for some other common checksum such as |
I use the xxHash shared library in a Perl6 package. 0.6.3 is broken for me, as it does not include 0.6.2's options to build a shared library. |
I'm surprised because xxHash release tarball never offered a However, the unofficial community-supported It was updated in v0.6.3, maybe that's when it was broken ? Edit : I tested the new Edit 2 : Actually, it's possible to build dynamic library with this script, it requires using flag |
Thanks, |
https://cmake.org/cmake/help/v3.0/variable/BUILD_SHARED_LIBS.html It's in the manual. It's also the default behaviour. If you're only getting static libraries by default, then something in your cmake script must be explicitly setting this to off (effectively changing the default). |
The According to your statement, it means that it should be set to Now, if it's enough to just add an option line with |
Since there are users of the library in binary format, |
@Cyan4973 Could you please tag a new release? I'd like to use the updated Makefile when packaging xxHash for Gentoo. Cheers, |
xxHash v0.6.4 has been released |
Thank you! |
Please do not strip the install targets from the Makefile. I am packaging xxHash for Gentoo Linux, and noticed that the Makefile is incomplete compared to what's in the git repository.
The text was updated successfully, but these errors were encountered: