Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation on RHEL 7 ppc64le (gcc 4.8) #631

Merged
merged 1 commit into from Dec 1, 2021
Merged

Fix compilation on RHEL 7 ppc64le (gcc 4.8) #631

merged 1 commit into from Dec 1, 2021

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Nov 30, 2021

This fixes #622.

Cyan4973
Cyan4973 approved these changes Dec 1, 2021
View reviewed changes
Copy link
Owner

@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ellert , the fix looks good to me.

I'm just wondering if we should pair it with some kind of extension to our CI tests, covering the scenario that was just fixed, to avoid regressions in the future.

@t-mat t-mat mentioned this pull request Dec 1, 2021
Closed
@t-mat
Copy link
Contributor

t-mat commented Dec 1, 2021

I'm just wondering if we should pair it with some kind of extension to our CI tests, covering the scenario that was just fixed, to avoid regressions in the future.

#624 and its PR will introduce proper CI tests for this PR and issue.
To keep repos green, I'd like to send a PR for CI test after this PR/issue will be resolved.

@Cyan4973 Cyan4973 merged commit 56ac11e into Cyan4973:dev Dec 1, 2021
@ellert ellert deleted the rhel7-ppc64le branch December 1, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xxhash 0.8.1 fails to compile on RHEL 7 ppc64le
3 participants
@ellert @t-mat @Cyan4973