do no longer depend on <assert.h> for XXH_STATIC_ASSERT
#670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since some versions are buggy. Use `_Static_assert` instead, which is part of the C11 language.
|
Had a lot of troubles due to this when trying to build borgbackup 1.1.18 release on FreeBSD 12. The xxhash package in ports does not have this patch and the build is stumbling over "undefined symbol static_assert". Not sure why this worked ok for 1.1.17 release. Would be cool to have a new xxhash release with all the fixes since last release. |
ThomasWaldmann
added a commit
to ThomasWaldmann/borg
that referenced
this pull request
Jun 5, 2022
Cyan4973/xxHash#670 this fixes building borgbackup on FreeBSD 12.x (when using the bundled xxhash code). otherwise i got "undefined symbol static_assert".
ThomasWaldmann
added a commit
to ThomasWaldmann/borg
that referenced
this pull request
Jun 5, 2022
Cyan4973/xxHash#670 this fixes building borgbackup on FreeBSD 12.x (when using the bundled xxhash code). otherwise i got "undefined symbol static_assert".
|
I also see the same problem on uClibc toolchains. This fix seems to be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since some versions of this library are buggy (ex:
uclibc).use
_Static_assertinstead, which is directly part of theC11language.fix #664 .