Full acc loop

[hzhuang1]

It's a replacement patch set of (#692).

With this patch set, empty parameter is totally avoided.

[hzhuang1]

What's wrong with this issue? Any suggestion to fix this issue?

[Cyan4973]

Unfortunately, I'm unable to help directly on this topic.
The tipi tests and build script were created by @pysco68 in #688.

[hzhuang1]

@pysco68 Yannic, there're some errors on tipi build. I don't have any more logs.

1. No permission on accessing /root/.docker/config.jason file.
2. Can't create git repository.

Could you help to share any suggestion on these issues?

Thanks

[hzhuang1]

@Cyan4973 Yann, I tried to download tipi to my local x86 machine. With an example file on testing xxhash interface, local tipi could build example and xxhash successfully. And it could print out the result as expected. If I switch to run tipi with remote server, it claims that payment is required.

Whatever, tipi could work. But I don't know why it reports error at here. I think it doesn't block our mission. Could we just ignore this checking error on tipi build?

[pysco68]

hey @Cyan4973 @hzhuang1 sorry for my delayed response, for some reasons the github notifications for xxhash we spam-canned and I didn't see this was going on.

We have a fix scheduled for release that should solve the bug the CI is experiencing, so if you're comfortable with leaving things as-is it should just start working again soon.

Otherwise you could patch-up the github CI workflow:

  tipi-build-linux:
    name: tipi.build project build and dependency resolution 
    runs-on: ubuntu-latest
    container: tipibuild/tipi-ubuntu

    env:
      HOME: /root

    steps:

      - uses: actions/checkout@v2
         # FIX: we currently need a full clone
         with:
          fetch-depth: '0' 
      - run: |
          mkdir -p /usr/local/share/.tipi   
          # FIX: Hack for github action       
          git config --global --add safe.directory /usr/local/share/.tipi
          git config --global --add safe.directory /__w/xxHash/xxHash/

      # checking if the xxHash project builds and passes tests
      - name: Build as project target linux-cxx17 (run test multiInclude)
        run: tipi . --dont-upgrade --verbose --test multiInclude -t linux-cxx17

      - name: Build as project target linux-cxx20 (run test multiInclude)
        run: tipi . --dont-upgrade --verbose --test multiInclude -t linux-cxx20

      - name: Cleanup project builds
        run: rm -r ./build

      # trying if pulling the dependency with tipi works properly
      - name: Build as dependency
        run: |
          cd ./cli
          tipi . --dont-upgrade --verbose -t linux-cxx17
          ./build/linux-cxx17/bin/xsum_os_specific

I'm happy to contribut a patch, but given that it should just start working again this is probably unecessary work for everyone involved.

@hzhuang1 the CI as implemented here doesn't do a "remote build" but rather a "local one" but on the GH node. Shameless plug: If you'd like to give the remote builds a try, you're welcome to start a free trial with us ;)

[hzhuang1]

Copy the code snippet from Yannic, and create the pull request #749.

[hzhuang1]

@Cyan4973 Could you help to share any comment on this pull request?

[Cyan4973]

I have a pretty full week unfortunately.
I'm likely going to find some time for it by the end of the week.

[hzhuang1]

No problem. Thanks a lot.

[hzhuang1]

The latest simplified version is in #756. So close it now.