Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XXH_UNREACHABLE feature test for C++23 and remove for C23 #791 #792

Merged
merged 1 commit into from Feb 23, 2023
Merged

Fix XXH_UNREACHABLE feature test for C++23 and remove for C23 #791 #792

merged 1 commit into from Feb 23, 2023

Commits on Feb 1, 2023

  1. Fix XXH_UNREACHABLE feature test for C++23 and remove for C23 Cyan4… 

    …973#791

gcc11/12 don't support `std::unreachable()` in there `-std=c++23`
build.

A more reliable check is:
```
```
so use that.

A similiar issue may occur for C23 `unreachable()` so just remove it
on the basis that if a compiler doesn't currently support some
builtin for unreachable/assume its very likely not using it in
analysis so we are probably not missing much (if anything)
leaving it out.
    @goldsteinn
    goldsteinn committed Feb 1, 2023
    Copy the full SHA
    35031d3 View commit details
    Browse the repository at this point in the history