Feature: Support # comment lines in --check files #838
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes issue Cyan4973#836. Basically, we just follow the following logic in the digest.c of GNU coreutils. https://github.com/coreutils/coreutils/blob/d53190ed46a55f599800ebb2d8ddfe38205dbd24/src/digest.c#L1180-L1182 Note that we only allow '#' at the beginning of the line.
Add "case GetLine_comment:" to conform -Werror=switch-enum.
```
cli/xxhsum.c: In function ‘XSUM_parseFile1’:
cli/xxhsum.c:814:17: error: enumeration value ‘GetLine_comment’ not handled in switch [-Werror=switch-enum]
814 | switch (XSUM_getLineResult)
| ^~~~~~
```
|
tipi.build fails for some reason. I have no idea though 😿 
|
|
The That's mostly because this test downloads a container with a changing content, occasionally breaking established behavior, a symptom of an evolving experimental project. It's probably best to remove this test from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #836.
Basically, we just follow the following logic in the
digest.cof GNU coreutils.https://github.com/coreutils/coreutils/blob/d53190ed46a55f599800ebb2d8ddfe38205dbd24/src/digest.c#L1180-L1182
This PR also contains a trivial test shell script,
Makefileentries andci.ymlentry for it.