Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Intel compiler's warning for XXH_ASSERT() #867

Merged
merged 1 commit into from Jul 16, 2023

Conversation

t-mat
Copy link
Contributor

@t-mat t-mat commented Jul 15, 2023

Intel compiler expects unsigned char as an argument of __builtin_assume().
Without this patch, it reports the following warnings to all XXH_ASSERT()s.

In file included from xxhash.c(43):
xxhash.h(6737): warning #2259: non-pointer conversion from "int" to "unsigned char" may lose significant bits
      XXH_ASSERT(secretBuffer != NULL);
      ^

Intel compiler expects "unsigned char" as an argument of __builtin_assume().
@Cyan4973
Copy link
Owner

This makes me think :
do we have an icc test in CI ?

@t-mat
Copy link
Contributor Author

t-mat commented Jul 16, 2023

do we have an icc test in CI ?

Yeah. Sometimes we have icc related issue, it should be in the CI.

Since there's official blog article, it seems it can be done relatively easily.

Adding Intel oneAPI toolkits to GitHub actions | Intel DevMesh

@Cyan4973 Cyan4973 merged commit 9e1cf4e into Cyan4973:dev Jul 16, 2023
58 checks passed
@t-mat t-mat deleted the fix/intel-compiler-assert branch July 16, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants