Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUP MESO and TVS product #94

Merged
merged 3 commits into from
Aug 23, 2023
Merged

PUP MESO and TVS product #94

merged 3 commits into from
Aug 23, 2023

Conversation

zzysupernova
Copy link
Contributor

在cinrad.io.level3.StandardPUP中,参考读取冰雹hail的代码,添加了读取PUP的中气旋MESO以及龙卷涡旋特征TVS的部分。
尝试读MESO和TVS的结果print如下:
image
image

@CyanideCN
Copy link
Owner

总体来说没啥问题,但是这个diff好奇怪,怎么把每一行都算作改动了。这样的话浏览真正的改动就有点麻烦,我看看能不能调

meso_count = np.frombuffer(self.f.read(4), "i4")[0]
feature_count = np.frombuffer(self.f.read(4), "i4")[0]
meso_table = np.frombuffer(self.f.read(meso_count* 68), L3_meso)
feature_table = np.frombuffer(self.f.read(feature_count* 72), L3_feature)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storm_count和feature_table都没用上,导出的Dataset里要加上吗

cinrad/io/level3.py Outdated Show resolved Hide resolved
@CyanideCN
Copy link
Owner

改的时候就别再用github的网页端上传整个文件了,不然diff又是一团糟

改成了循环,还是保留了DataArray,去掉的话因为后面lon和lat的关系似乎会影响输出结构
@zzysupernova
Copy link
Contributor Author

改的时候就别再用github的网页端上传整个文件了,不然diff又是一团糟

好嘞,刚开始用github刚学python,都是照抄你的写的><
谢谢你写的库!读新的pup产品帮大忙了!

@CyanideCN
Copy link
Owner

感觉没啥问题了,merge啦

@CyanideCN CyanideCN merged commit d987a53 into CyanideCN:master Aug 23, 2023
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants