Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests with Python 3.10 #109

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Run tests with Python 3.10 #109

merged 1 commit into from
Aug 29, 2022

Conversation

c-bata
Copy link
Collaborator

@c-bata c-bata commented Apr 8, 2022

This PR aims to support Python 3.10. Note that 3.10 must be quoted, otherwise tests are executed with Python 3.1.

@c-bata c-bata mentioned this pull request Apr 8, 2022
Closed
@c-bata
Copy link
Collaborator Author

c-bata commented Apr 8, 2022 •
edited
Loading

It seems that we need to reformat Python codes by the latest version of black. I fixed it in a separated pull request.

Could you check #110 ahead? I will rebased this branch after #110 is merged.

@c-bata c-bata marked this pull request as draft April 8, 2022 21:24
@c-bata c-bata marked this pull request as ready for review August 29, 2022 06:35
@c-bata
Copy link
Collaborator Author

c-bata commented Aug 29, 2022

@nomuramasahir0 Could you review this PR?

@nomuramasahir0
Copy link
Collaborator

@c-bata Thanks! LGTM!

@nomuramasahir0 nomuramasahir0 merged commit 32b4755 into CyberAgentAILab:main Aug 29, 2022
@c-bata c-bata deleted the patch-1 branch August 30, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c-bata @nomuramasahir0