Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

循环指令时,获取node错误 #63

Merged
merged 3 commits into from
Sep 18, 2019
Merged

循环指令时,获取node错误 #63

merged 3 commits into from
Sep 18, 2019

Conversation

tille1229
Copy link

@tille1229 tille1229 commented Aug 21, 2019

描述

修复循环下使用指令中获取node节点错误

操作

issue:close #62

类型

  • 修复 bug(没有不兼容的修改)
  • 新功能(没有不兼容的修改)
  • 不兼容的修改(修复 bug 或者新增功能时导致现有版本不能正常工作)

请确保已完成以下内容

  • 代码风格与本项目一致,并通过 npm run lint 校验
  • 如果需要修改文档,请修改(包含中英文文档)
  • 遵循 Semantic Versioning 2.0.0 修改版本号

@CyberNika
Copy link
Owner

CyberNika commented Aug 21, 2019

感谢 PR ;)
另外修改一下版本号吧,合并之后我就直接发一版了。

@tille1229
Copy link
Author

版本号调整为2.8.1,npm publish 后@me

@CyberNika
Copy link
Owner

@tille1229 看下上面的 review

Copy link
Author

@tille1229 tille1229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码已经审查

@tille1229
Copy link
Author

@snokier 代码何时进行合并?

src/directive.js Outdated Show resolved Hide resolved
@CyberNika CyberNika self-requested a review September 17, 2019 13:53
@CyberNika
Copy link
Owner

@tille1229 可以看到我 review 的 comment 吗?有个代码需要修改

1. Modify array judgment
@CyberNika CyberNika merged commit e50bb2f into CyberNika:master Sep 18, 2019
@CyberNika
Copy link
Owner

2.8.1 已发布

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

循环组件中引用 指令错误
2 participants