Grab first valid coin from multicoin announcement #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ if a multicoin annoucement is made, select the first valid coin
…-trading-bot-binance-announcements-new-coins into bugfix_multicoin_announcement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is the first step to fixing multicoin announcements.
The idea is to grab the first in a multi-coin announcement.
It also refactores some parts of the announcement detection to use a blacklist of words instead of a Whitelist.
If the announcement includes one of those words it will get ignored.
Idk yet if thats the best idea, my reasoning was that if the announcement message changes we will still detect it as long as there is no blacklisted word used and its easier to use the same function for multiple announcement providers in the future.
However as implemented in #142,the other approach is to write a scraper for every site which could handle the extraction of the coin from the announcement individually.