Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Bug in DownloadReportAsyncWithHttpInfo #36

Closed
xantari opened this issue Jun 27, 2019 · 6 comments
Closed

Critical Bug in DownloadReportAsyncWithHttpInfo #36

xantari opened this issue Jun 27, 2019 · 6 comments

Comments

@xantari
Copy link

xantari commented Jun 27, 2019

In the DownloadReportAsyncWithHttpInfo class when requesting a report you do not get any report data back!

I decompiled your library and found the issue.

I have highlighted issue in RED:

image

If you look at the non async version you get this:

image

You are missing restResponse.get_Content()!!!!

You are requesting everyone to convert to new REST Report download by 7/31/2019, but have such critical bug to disallow async function???

@Digiman
Copy link

Digiman commented Jul 2, 2019

As I remember i also found this problem and fix it in my form to make sure that i can use API and download report - this is main functionality for now that required to work. I am continue using my solution that works.
This repository and library contains a lot of issues (because for now I need only reports I have fixed it for me, other APIs - may also contains issues) that need to be resolved. But as I an see authors who work with it don't want to do this. It's horrible...(((

@xantari try to take a look on my fork - at least downloading reports is working.

Thanks.

@xantari
Copy link
Author

xantari commented Jul 2, 2019

@Digiman Thanks! I've started fixing the pieces so far that I have found for just the reporting infrastructure. It's unbelievable to me that only one Cybersource developer is assigned to this (and only part time as indicated by his checkin requests accross Python, Ruby, PHP, and C# librarys).

It's amazing to me that Cybersource is telling people to switch to the new REST API by 7/31/2019, but don't provide the proper client library abstractions to do so. Talk about the cart before the horse! Upper management at Cybersource should be rethinking their 7/31/2019 deadline in light of these issues. But alas, it is probably falling on deaf ears.

@Digiman
Copy link

Digiman commented Jul 8, 2019

@xantari Yep, I think so. It's really bad approach. I had discussion with guy from CyberSource (some kind manager) that talking and talking without stop. I said that library need to be improved but ... nothings changed.

It's part of he problem. Also they had issues inside report. It's more fully - it like as they don't have any testing (QA).

At least for now - my solution working. Hope it will work in future. Maybe in 1-2 years they will provide proper logic and working library)

@xantari
Copy link
Author

xantari commented Jul 24, 2019

Cybersource support case # 06135500 stated this works fine for them. They said "For issue 36, our engineers were able to receive the report information back in the console."

Here is the failing lines of code:

return new ApiResponse<Object>(localVarStatusCode,
localVarResponse.Headers.ToDictionary(x => x.Name, x => x.Value.ToString()),
null);

Here is the non-async working version lines of code:

return new ApiResponse<Object>(localVarStatusCode,
localVarResponse.Headers.ToDictionary(x => x.Name, x => x.Value.ToString()),
localVarResponse.Content);

You will notice that in the working non-async version above you have this: localVarResponse.Content

But it is missing in the Async version. This is where your bug is. You are not returning the content of the report in the Async version.

@gnongsie
Copy link
Contributor

gnongsie commented Aug 5, 2019

Hi,

Thank you for bringing this to our attention.

This issue has been addressed in the latest version of the SDK.
Kindly fetch the SDK from NuGet (v0.0.0.10) and check again.

@xantari
Copy link
Author

xantari commented Sep 17, 2019

Appears to be fixed

@xantari xantari closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants