Draft: Add Configuration File Option #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default config option file Add example TOML config Use pathlib rglob for submission file list
malvidin
changed the title
Move analyzer and submitter to consolidated argparse
Move analyzer and submitter to consolidated argparse Remove click requirement
malvidin
force-pushed
the
add_configfile
branch
from
0232346
to
c4146e7
Compare
Use refreshable Client for submitter threads Validate path argument to submitter Use logger as first argument to match other methods
|
@malvidin is this still relevant based on your changes to the AL client? CybercentreCanada/assemblyline_client#33 |
|
This is still relevant. These changes support using a configuration file to set common configurations for the incident manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a TOML config file option that will be overridden by any CLI options. Moved to use pathlib's Path().rglob() to walk the source directory for submissions. It also accepts single files as submissions.
Also formatted all Python files with Black.