Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to define column order of TableResult Sections #68

Closed
cccs-rs opened this issue Apr 28, 2023 · 2 comments
Closed

Add option to define column order of TableResult Sections #68

cccs-rs opened this issue Apr 28, 2023 · 2 comments
Assignees
@cccs-rs
Labels
accepted This issue was accepted, we will work on this at some point enhancement New feature or request In progress service-base ui-frontend

Comments

@cccs-rs
Copy link
Contributor

cccs-rs commented Apr 28, 2023

Is your feature request related to a problem? Please describe.
I am trying to order the Table Result section so certain columns show up first, at the moment is seems that it sorts them alphabetically ? is there a way to have it keep the order provided in the JSON?

Describe the solution you'd like
Maybe we could add an optional way to define the [column] order in the TableSection that the frontend could use?

Additional context
Discord
@cccs-rs cccs-rs added enhancement New feature or request assess We still haven't decided if this will be worked on or not service-base ui-frontend labels Apr 28, 2023
@cccs-sgaron cccs-sgaron added accepted This issue was accepted, we will work on this at some point and removed assess We still haven't decided if this will be worked on or not labels May 17, 2023
@cccs-sgaron
Copy link
Collaborator

We will add a body_config field to result section which will be a odm.mapping field. The table section will look for the column_order field in that body_config block and will apply the right order. If missing, the table will revert back to alphabetical.

We will also add a method to v4 service base table section to set the order.

This was referenced May 19, 2023
Merged
Merged
Merged
cccs-rs added a commit to CybercentreCanada/assemblyline-base that referenced this issue May 23, 2023
@cccs-rs
Merge pull request #1216 from CybercentreCanada/assemblyline/issues/68
0f968e1 
Add optional `body_config` field to ResultSection objects
cccs-rs added a commit to CybercentreCanada/assemblyline-v4-service that referenced this issue May 23, 2023
@cccs-rs
Merge pull request #621 from CybercentreCanada/assemblyline/issues/68
df14abd 
Assemblyline/issues/68
cccs-rs added a commit to CybercentreCanada/assemblyline-ui-frontend that referenced this issue May 23, 2023
@cccs-rs
Merge pull request #609 from CybercentreCanada/assemblyline/issues/68
e1c5ee1 
Allow TableSections to have custom column ordering
cccs-rs added a commit to CybercentreCanada/assemblyline-base that referenced this issue May 29, 2023
@cccs-rs
Merge pull request #1213 from CybercentreCanada/assemblyline/issues/68
1e8db2e 
Add optional `body_config` field to ResultSection objects
cccs-rs added a commit to CybercentreCanada/assemblyline-v4-service that referenced this issue May 29, 2023
@cccs-rs
Merge pull request #620 from CybercentreCanada/assemblyline/issues/68
44ee827 
Incorporate new `body_config` field into Section types
cccs-rs added a commit to CybercentreCanada/assemblyline-ui-frontend that referenced this issue May 29, 2023
@cccs-rs
Merge pull request #608 from CybercentreCanada/assemblyline/issues/68
9ec62fc 
Allow TableSections to have custom column ordering
@cccs-rs
Copy link
Contributor Author

cccs-rs commented May 30, 2023

Fixed in Release 4.4.0.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cccs-rs cccs-rs

Labels
accepted This issue was accepted, we will work on this at some point enhancement New feature or request In progress service-base ui-frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cccs-sgaron @cccs-rs