fix: New time range filter initially show advance section (apache#15889)

CybercentreCanada · Dec 17, 2021 · 0362df1 · 0362df1
1 parent a986eb9
commit 0362df1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/...board/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx b/...board/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
@@ -585,6 +585,10 @@ const FiltersConfigForm = (
 
   const defaultToFirstItem = formFilter?.controlValues?.defaultToFirstItem;
 
+  const hasAdvancedSection =
+    formFilter?.filterType === 'filter_select' ||
+    formFilter?.filterType === 'filter_range';
+
   const preFilterValidator = () => {
     if (hasTimeRange || hasAdhoc) {
       return Promise.resolve();
@@ -847,7 +851,7 @@ const FiltersConfigForm = (
               .filter(key => BASIC_CONTROL_ITEMS.includes(key))
               .map(key => controlItems[key].element)}
           </Collapse.Panel>
-          {((hasDataset && hasAdditionalFilters) || hasMetrics) && (
+          {hasAdvancedSection && (
             <Collapse.Panel
               forceRender
               header={FilterPanels.advanced.name}