chore(trino): remove unnecessary index checks (apache#25211)

CybercentreCanada · Sep 9, 2023 · a77ccb4 · a77ccb4
1 parent 4f37efa
commit a77ccb4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/superset/db_engine_specs/presto.py b/superset/db_engine_specs/presto.py
@@ -527,12 +527,13 @@ def _latest_partition_from_df(cls, df: pd.DataFrame) -> list[str] | None:
 
     @classmethod
     @cache_manager.data_cache.memoize(timeout=60)
-    def latest_partition(
+    def latest_partition(  # pylint: disable=too-many-arguments
         cls,
         table_name: str,
         schema: str | None,
         database: Database,
         show_first: bool = False,
+        indexes: list[dict[str, Any]] | None = None,
     ) -> tuple[list[str], list[str] | None]:
         """Returns col name and the latest (max) partition value for a table
 
@@ -542,12 +543,15 @@ def latest_partition(
         :type database: models.Database
         :param show_first: displays the value for the first partitioning key
           if there are many partitioning keys
+        :param indexes: indexes from the database
         :type show_first: bool
 
         >>> latest_partition('foo_table')
         (['ds'], ('2018-01-01',))
         """
-        indexes = database.get_indexes(table_name, schema)
+        if indexes is None:
+            indexes = database.get_indexes(table_name, schema)
+
         if not indexes:
             raise SupersetTemplateException(
                 f"Error getting partition for {schema}.{table_name}. "
@@ -1221,7 +1225,7 @@ def extra_table_metadata(
 
         if indexes := database.get_indexes(table_name, schema_name):
             col_names, latest_parts = cls.latest_partition(
-                table_name, schema_name, database, show_first=True
+                table_name, schema_name, database, show_first=True, indexes=indexes
             )
 
             if not latest_parts:

diff --git a/superset/db_engine_specs/trino.py b/superset/db_engine_specs/trino.py
@@ -60,7 +60,11 @@ def extra_table_metadata(
 
         if indexes := database.get_indexes(table_name, schema_name):
             col_names, latest_parts = cls.latest_partition(
-                table_name, schema_name, database, show_first=True
+                table_name,
+                schema_name,
+                database,
+                show_first=True,
+                indexes=indexes,
             )
 
             if not latest_parts: