Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added set_long, set_float and set_atoms methods to min::instance class #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added set_long, set_float and set_atoms methods to min::instance class #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions include/c74_min_patcher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,19 @@ namespace c74::min {
max::object_attr_setchar(m_instance, attribute_name, value);
}

void set_long(const symbol attribute_name, const long value) {
max::object_attr_setlong(m_instance, attribute_name, value);
}

void set_float(const symbol attribute_name, const float value) {
max::object_attr_setfloat(m_instance, attribute_name, value);
}

void set_atoms(const symbol attribute_name, atoms values) {
if (values.size () > 0)
max::object_attr_setvalueof(m_instance, attribute_name, values.size (), (max::atom*)&values[0]);
}

Comment on lines +136 to +148
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other set methods use overloads, should these all just be named set ?

also, on windows i don't think long matches t_atom_long so maybe this should use that instead of long ?

template<typename T>
T get(const symbol attribute_name) const {
long argc {};
Expand Down