feat(server): switch middleware from connect to express #1076
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
added
enhancement
Signed-off-by: Adam Setch <adam.setch@outlook.com>
| @@ -2220,8 +2220,8 @@ test("parsePkgLock v3", async () => { | |||
| projectName: "cdxgen", | |||
| }); | |||
| deps = parsedList.pkgList; | |||
| expect(deps.length).toEqual(842); | |||
There was a problem hiding this comment.
I am not sure about using the full express since it is bringing 19 more packages. Any issues with connect?
There was a problem hiding this comment.
Yes, as mentioned in #1075 connect hasn't seen a single commit in ~4 years. I'd consider this critical to replace with something maintained and current.
Additionally, I have a local branch shortly ready to share based on express that can generate an OpenAPI Specification from jsdocs, so that we can avoid using md to document API Specifications
There was a problem hiding this comment.
Express appears to be using connect internally. OpenAPI sounds interesting, too.
| @@ -8246,6 +8498,20 @@ | |||
| "url": "https://github.com/sponsors/sindresorhus" | |||
| } | |||
| }, | |||
| "node_modules/serve-static": { | |||
There was a problem hiding this comment.
These are very old packages. I am still not convinced about express.
| "integrity": "sha512-XGuRDNjXUijsUL0vl6nSD7cwURuzEgglbOaFuZM9g3kwDXOWVTck0jLzjPzGD+TazWbboZYu52/9/XPdUgne9g==", | ||
| "dependencies": { | ||
| "encodeurl": "~1.0.2", | ||
| "escape-html": "~1.0.3", |
There was a problem hiding this comment.
|
Switching to express not desirable at this time... |
Closes #1075