Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo deep mode #1102

Merged
merged 12 commits into from
May 21, 2024
Merged

cargo deep mode #1102

merged 12 commits into from
May 21, 2024

Conversation

prabhu
Copy link
Contributor

@prabhu prabhu commented May 20, 2024

Fixes #1065 #1066 #919

With --deep mode, cargo check command is invoked to automatically include the information from .d files.

For build lifecycle, cargo generate-lockfile is invoked when options.installDeps is also set.

With FETCH_LICENSE, more properties such as rust_version, features etc are collected.

An extra change added by this commit is to set the gradle root path based on the first build.gradle file, in case the root directory doesn't contain build.gradle or settings.gradle files. @heubeck @setchy @ajmalab can you test and ensure this doesn't break things for you guys?

@Lucasljungberg Could you kindly test this PR and let me know your thoughts?

utils.js Dismissed Show dismissed Hide dismissed
index.js Dismissed Show dismissed Hide dismissed
index.js Dismissed Show dismissed Hide dismissed
index.js Dismissed Show dismissed Hide dismissed
index.js Dismissed Show dismissed Hide dismissed
index.js Dismissed Show dismissed Hide dismissed
index.js Dismissed Show dismissed Hide dismissed
index.js Dismissed Show dismissed Hide dismissed
prabhu added 12 commits May 21, 2024 10:32
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
…mponent was found in multiple SrcFiles, it can be retained. Fixed a bug in gradle to figure out the root path in case of monorepos. Support for distribution in external references.

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@heubeck
Copy link
Contributor

heubeck commented May 21, 2024

no issues with my existing test-cases, thank you @prabhu!

@aryan-rajoria
Copy link
Collaborator

I have built and run the docker container on the following rust repos flawz, gitui, Bend and meilisearch. It is generating the BOM file successfully

@prabhu prabhu merged commit 245ad22 into master May 21, 2024
24 checks passed
@prabhu prabhu deleted the feature/cargo-deep-mode branch May 21, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants