Add IRI Validation for externalReference URL #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Messing <141575989+timmyteo@users.noreply.github.com>
Signed-off-by: Tim Messing <141575989+timmyteo@users.noreply.github.com>
Signed-off-by: Tim Messing <141575989+timmyteo@users.noreply.github.com>
prabhu
approved these changes
Jun 5, 2024
| const result = validateIri(iri, IriValidationStrategy.Strict); | ||
|
|
||
| if (result instanceof Error) { | ||
| return false; |
There was a problem hiding this comment.
Maybe log the url in debug mode?
Signed-off-by: Tim Messing <141575989+timmyteo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @prabhu, this pull request is to address #1107 and is an alternative to the open pull request #1130
This adds the validate-iri dependency to be used to filter out invalid IRI in the BOM for externalReferences