Ensure All Required Dependencies are Included in PNPM v9 #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By traversing all required dependencies, we can explicitly remove any optional scoping that was added earlier in the parsePnpmLock method. Also fixes some tests and adds some new tests to ensure parsePnpmLock works appropriately. Signed-off-by: Chris Bowers <pcbowers@gmail.com>
|
@prabhu Feel free to make edits to this, but this should fix the issue where shared dependencies between required and optional dependencies were marked as optional instead of required. |
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
|
Thanks @pcbowers for allowing edits. I made some simple changes, but it looked good otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1183 By explicitly removing the optional scope
By traversing all required dependencies, we can explicitly remove any optional scoping that was added earlier in the parsePnpmLock method. Also fixes some tests and adds some new tests to ensure parsePnpmLock works appropriately.