Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(server): update to highlight that comma separated types are supported #1277

Merged
merged 1 commit into from
Jul 26, 2024
Merged

docs(server): update to highlight that comma separated types are supported #1277

merged 1 commit into from
Jul 26, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jul 25, 2024 •
edited
Loading

No description provided.

@setchy
docs: update server type to highlight that comma separated types are …
605a542 
…supported

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy requested a review from prabhu as a code owner July 25, 2024 22:22
@setchy setchy added the documentation Improvements or additions to documentation label Jul 25, 2024
@setchy setchy changed the title docs: update server type to highlight that comma separated types are … docs(server): update to highlight that comma separated types are supported Jul 25, 2024
@setchy setchy added the mode:server cdxgen used as server label Jul 25, 2024
prabhu
prabhu approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@prabhu prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if making type an array is a breaking change, so went with this approach

@setchy setchy merged commit c4f812f into master Jul 26, 2024
17 checks passed
@setchy setchy deleted the docs/update-server-type branch July 26, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhu prabhu prabhu approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation mode:server cdxgen used as server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@setchy @prabhu