Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(biome): fix useless else cases #988

Merged
merged 1 commit into from
Apr 16, 2024
Merged

chore(biome): fix useless else cases #988

merged 1 commit into from
Apr 16, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 15, 2024 •
edited

@setchy
chore(biome): fix useless else cases
20a6082 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
prabhu
prabhu approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@prabhu prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! GitHub diff ui is showing more unrelated diffs than necessary since it is not semantic.

@setchy setchy marked this pull request as draft April 16, 2024 09:10
@setchy setchy closed this Apr 16, 2024
@prabhu
Copy link
Contributor

prabhu commented Apr 16, 2024

@setchy this can be merged. Were the tests failing?

@setchy
Copy link
Member Author

setchy commented Apr 16, 2024

What did you mean by

GitHub diff ui is showing more unrelated diffs than necessary since it is not semantic.

@setchy setchy reopened this Apr 16, 2024
@prabhu
Copy link
Contributor

prabhu commented Apr 16, 2024

What did you mean by

GitHub diff ui is showing more unrelated diffs than necessary since it is not semantic.

I was commenting about the limitation of github ui.

@setchy setchy marked this pull request as ready for review April 16, 2024 13:53
@setchy setchy merged commit 9cadc75 into CycloneDX:master Apr 16, 2024
29 checks passed
@setchy
Copy link
Member Author

setchy commented Apr 16, 2024

Ah, ok. Merged now

@setchy setchy deleted the fix/biome-useless-elseif branch April 16, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhu prabhu prabhu approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@setchy @prabhu