Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #367

Merged
merged 3 commits into from
May 20, 2024
Merged

Fix build #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0da6c0e
Fix build
andreas-hilti May 20, 2024
a8bf0b1
activate SNAPSHOOTER_STRICT_MODE
andreas-hilti May 20, 2024
201415e
Fix release
andreas-hilti May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/dotnetcore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: .NET Core CI

on: [pull_request, workflow_dispatch]

env:
SNAPSHOOTER_STRICT_MODE: true

jobs:
# Fail if there are build warnings
#
Expand Down Expand Up @@ -49,7 +52,9 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
# os: [ubuntu-latest, windows-latest, macos-latest]
# macos currently disabled. see issue https://github.com/SwissLife-OSS/snapshooter/issues/196.
os: [ubuntu-latest, windows-latest]
timeout-minutes: 30

steps:
Expand All @@ -58,6 +63,15 @@ jobs:
with:
dotnet-version: '6.0'

- name: SnapshooterHotfixSymlinkLinux
if: matrix.os == 'ubuntu-latest'
run: sudo ln -s "$GITHUB_WORKSPACE" /_
shell: bash
- name: SnapshooterHotfixSymlinkWindows
if: matrix.os == 'windows-latest'
run: New-Item -ItemType SymbolicLink -Path "/_" -Target "$env:GITHUB_WORKSPACE"
shell: pwsh

- name: Tests
run: |
dotnet restore
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ name: Release
on:
workflow_dispatch

env:
SNAPSHOOTER_STRICT_MODE: true

jobs:
release:
name: Release
Expand All @@ -35,6 +38,9 @@ jobs:
- uses: actions/setup-dotnet@v3.0.2
with:
dotnet-version: '6.0'
- name: SnapshooterHotfixSymlinkLinux
run: sudo ln -s "$GITHUB_WORKSPACE" /_
shell: bash
# The tests should have already been run during the PR workflow, so this is really just a sanity check
- name: Tests
run: dotnet test
Expand Down