Fix issue with License Serialization - Issue 408 and 409 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-zepol
force-pushed
the
408_regression
branch
3 times, most recently
from
0bf7775
to
58726ff
Compare
mr-zepol
changed the title
mr-zepol
force-pushed
the
408_regression
branch
2 times, most recently
from
425c5fb
to
763b51d
Compare
nscuro
reviewed
May 26, 2024
src/main/java/org/cyclonedx/util/serializer/LicenseChoiceSerializer.java
Outdated
Show resolved
Hide resolved
mr-zepol
force-pushed
the
408_regression
branch
2 times, most recently
from
6223a90
to
573b046
Compare
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
nscuro
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
#409
#408
There is still some code simplification that can be done, but given the urgency and the need for a solution, it'll be done in a different PR