Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalizer MUST assert LicenseExpression xor DisjunctiveLicense* #602

Closed
jkowalleck opened this issue Mar 31, 2023 · 0 comments · Fixed by #623
Closed

Normalizer MUST assert LicenseExpression xor DisjunctiveLicense* #602

jkowalleck opened this issue Mar 31, 2023 · 0 comments · Fixed by #623
Assignees
Labels
bug Something isn't working

Comments

@jkowalleck
Copy link
Member

based on https://github.com/CycloneDX/specification/blob/1.4/schema/bom-1.4.xsd#L1398-L1408

a licenses list must be either exactly one expression, or any amount of license.

expression is to be preferred (arguably)


Current data model allwes a mix like

<licenses>
  <license><id>MIT</id></license>
  <expression>MIT OR Apache-2.0</expression>
  <license><name>something</name></license>
</licenses>

but it must be either

<licenses>
  <license><id>MIT</id></license>
  <license><name>something</name></license>
</licenses>

OR

<licenses>
  <expression>MIT OR Apache-2.0</expression>
</licenses>

... for JSON it is equally a thing ...

@jkowalleck jkowalleck added the bug Something isn't working label Mar 31, 2023
@jkowalleck jkowalleck changed the title Normalizer MUST assert LicenseExpression or DisjunctiveLicense Normalizer MUST assert LicenseExpression xor DisjunctiveLicense* Mar 31, 2023
jkowalleck added a commit that referenced this issue Apr 3, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Apr 3, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck self-assigned this Apr 4, 2023
jkowalleck added a commit that referenced this issue Apr 5, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Apr 5, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant