Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardenFactories.FromNodePackageJson.PackageUrlFactory's default package repository detection #1074

Merged
merged 9 commits into from
May 21, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented May 20, 2024

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the bug Something isn't working label May 20, 2024
Copy link

codacy-production bot commented May 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (74404ed) 22902 22491 98.21%
Head commit (a5a101d) 22917 (+15) 22506 (+15) 98.21% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1074) 12 12 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review May 21, 2024 11:11
@jkowalleck jkowalleck requested a review from a team as a code owner May 21, 2024 11:11
@jkowalleck jkowalleck changed the title [WIP] fix: harden npmDefaultRegistryMatcher fix: harden npmDefaultRegistryMatcher May 21, 2024
@jkowalleck jkowalleck changed the title fix: harden npmDefaultRegistryMatcher fix: hardenFactories.FromNodePackageJson.PackageUrlFactory's default package repository detection May 21, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit ce35e84 into main May 21, 2024
44 checks passed
@jkowalleck jkowalleck deleted the fix/harden-npmDefaultRegistryMatcher branch May 21, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: harden npmDefaultRegistryMatcher
1 participant