Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle XML normalizedString/token #1116

Merged
merged 17 commits into from
Jul 3, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jul 3, 2024

fixes #1098

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the bug Something isn't working label Jul 3, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner July 3, 2024 08:29
@jkowalleck jkowalleck marked this pull request as draft July 3, 2024 08:29
@jkowalleck jkowalleck changed the title fix: XML normalizedString [wip] fix: XML normalizedString Jul 3, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the fix/xml_normalizedString_token branch from 3e58ae1 to d21d266 Compare July 3, 2024 10:06
Copy link

codacy-production bot commented Jul 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b209685) 23310 22912 98.29%
Head commit (38449e6) 23562 (+252) 23164 (+252) 98.31% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1116) 117 117 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [wip] fix: XML normalizedString fix: XML normalizedString Jul 3, 2024
@jkowalleck jkowalleck changed the title fix: XML normalizedString fix: XML normalizedString and token Jul 3, 2024
@jkowalleck jkowalleck marked this pull request as ready for review July 3, 2024 11:27
@jkowalleck jkowalleck changed the title fix: XML normalizedString and token fix: properly handle XML normalizedString/token Jul 3, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit 5f76549 into main Jul 3, 2024
24 of 25 checks passed
@jkowalleck jkowalleck deleted the fix/xml_normalizedString_token branch July 3, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XML] properly handle normalizedString & token
1 participant